[runx] Allow non-archived binaries #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcurtis
approved these changes
Oct 10, 2023
| } | ||
|
|
||
| func createSymbolicLink(src, dest, repoName string) error { | ||
| if err := fileutil.EnsureDir(dest); err != nil { |
Contributor
There was a problem hiding this comment.
This could just be os.MkdirAll.
Comment on lines
73
to
75
| if errors.Is(err, os.ErrExist) { | ||
| return nil | ||
| } |
Contributor
There was a problem hiding this comment.
Might want to check that the symlink is pointing to the right binary if it already exists in case the user ever installs a different version.
Contributor
Author
There was a problem hiding this comment.
The symlink is already in a versioned directory: (Both the symlink and the source)
ls -al ~/Library/Caches/jetpack.io/pkgs/mvdan/gofumpt/v0.5.0/darwin/arm64/
gofumpt -> /Users/mike/Library/Caches/jetpack.io/pkgs/mvdan/gofumpt/v0.5.0/gofumpt_v0.5.0_darwin_arm64
So nice to have in case we ever change the download logic but not urgent. Will add TODO
| if isKnownArchive(filepath.Base(artifactPath)) { | ||
| err = Extract(ctx, artifactPath, installPath.String()) | ||
| } else { | ||
| // If we can't extract, treat as binary |
Contributor
There was a problem hiding this comment.
Checking the first 4 bytes would be a pretty good heuristic for determining if it's meant to be executable:
#!= shell script0x7f454c46= ELF (Linux)0xfeedface= macho 32 bit binary (macOS)0xfeedfacf= macho 64 bit binary (macOS)0xcafebabe= macho universal binary (macOS)
Contributor
Author
There was a problem hiding this comment.
Looks like I also need to add little endian for mac binaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some repos (e.g. https://github.com/mvdan/gofumpt) release files as binaries instead of archives. This expands runx to treat unknown files (that still match the platform and architecture name structure) as binaries. It only does so if it finds a compatible artifact but the type is unknown.
We could additionally test the mime type of the file, but it doesn't seem like binaries use consistent mime types.
How was it tested?
./dist/runx +mvdan/gofumpt gofumpt --help