Skip to content

[aisdk] Allow for empty reasoning blocks (observed behavior) #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
Merged

[aisdk] Allow for empty reasoning blocks (observed behavior) #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7276a38
[aisdk] Allow for empty reasoning blocks (observed behavior)
ipince Nov 13, 2025
fa86734
fix test
ipince Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions aisdk/ai/provider/openai/internal/codec/decode.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,6 @@ func decodeReasoning(item responses.ResponseOutputItemUnion) (*api.ReasoningBloc
}

reasoningItem := item.AsReasoning()
if len(reasoningItem.Summary) == 0 {
return nil, fmt.Errorf("reasoning item has no summary")
}

// For now, we'll concatenate all summary texts with newlines if there are multiple
// Another option would be to return a slice of ReasoningBlocks.
Expand All @@ -125,9 +122,9 @@ func decodeReasoning(item responses.ResponseOutputItemUnion) (*api.ReasoningBloc
texts = append(texts, summary.Text)
}

if len(texts) == 0 {
return nil, fmt.Errorf("no valid text found in reasoning summaries")
}
// NOTE: we don't check that the text is non-empty because sometimes the model returns an empty
// reasoning block. That behavior is technically against the API spec, but it's been observed in practice.
// Consider omitting the ReasoningBlock and adding a warning instead.

return &api.ReasoningBlock{
Text: strings.Join(texts, "\n"),
Expand Down
2 changes: 1 addition & 1 deletion aisdk/ai/provider/openai/internal/codec/decode_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ func TestDecodeReasoning(t *testing.T) {
"id": "reason_123",
"summary": []
}`,
wantErr: "reasoning item has no summary",
want: &api.ReasoningBlock{},
},
{
name: "empty text in summary",
Expand Down
Loading