refactoring network stack (and static ip) #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ym
changed the title
Closed
IDisposable
reviewed
Oct 14, 2025
| setNetworkSettings({ ...networkSettings, lldp_mode: value as LLDPMode }); | ||
| }; | ||
| // Build list of critical changes for display | ||
| const changes: { label: string; from: string; to: string }[] = []; |
Contributor
There was a problem hiding this comment.
Some properties need to be confirmed in a modal.
| confirmText="Apply changes" | ||
| onConfirm={() => { | ||
| setShowCriticalSettingsConfirm(false); | ||
| if (stagedSettings) onSubmit(stagedSettings); |
Contributor
There was a problem hiding this comment.
Once confirmed, we call the actualy onSubmit()
| } | ||
| } | ||
|
|
||
| if (resp.method === "willReboot") { |
Contributor
There was a problem hiding this comment.
If the device sends us a willReboot message, we navigate to the root route and show the reboot overlay.
Currently, we have two flows using this:
- Click on reboot, which will send
willRebootright before actually rebooting - Given a certain network change, the backend will send this
In the future we can use this flow for the OTA.
|
|
||
| if rebootNeeded { | ||
| scopedLogger.Info().Msg("System Rebooting in 10s") | ||
|
|
Contributor
There was a problem hiding this comment.
We can use the willReboot flow for the OTA too. Might need some tweaking, but the flow and interface should be enough.
adamshiervani
approved these changes
Oct 14, 2025
…4Card and StaticIpv6Card components
IDisposable
approved these changes
Oct 15, 2025
Contributor
|
Now I have to rebase the localization :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI TODO:
Hostnamefield.Savebutton doesn't work (this might require fixing the Tailwind animation class).MAC Addressfield is read-only, but the style is the same. We should probably change it tospaninstead of 'input'.Apply network settingsconfirmation dialog also closes the whole settings tab instead of the confirmation dialog.subnet maskoptional for IPv4 static address, hide it if/is detected.Backend TODO:
Classless Static Route Option6rdIEEE 802.1Q VLAN ID