chore: disable sleep mode when detecting video format #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamshiervani
approved these changes
Oct 16, 2025
1 task
1 task
Implemented a new feature to enable or disable HDMI sleep mode, allowing users to reduce power consumption when the device is not in use. Added state management for the power saving setting and integrated it with the existing settings page.
IDisposable
approved these changes
Oct 17, 2025
V4L2 buffers were not explicitly freed before closing the device, causing VIDIOC_S_FMT to fail with EBUSY on restart. Added VIDIOC_REQBUFS(count=0) call in cleanup to free buffer queue synchronously before close(). This ensures subsequent opens can set format immediately without EBUSY errors, eliminating 100ms+ retry delays.
|
|
ym
added a commit
that referenced
this pull request
Oct 17, 2025
Co-authored-by: Adam Shiervani <adam.shiervani@gmail.com> Co-authored-by: Adam Shiervani <adamshiervani@fastmail.com>
ym
added a commit
that referenced
this pull request
Oct 17, 2025
Co-authored-by: Adam Shiervani <adam.shiervani@gmail.com> Co-authored-by: Adam Shiervani <adamshiervani@fastmail.com>
IDisposable
reviewed
Oct 17, 2025
Contributor
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
I know this already merged, but I had a couple questions/comments
| // it's used to ensure that only one change is made to the video stream at a time. | ||
| // as the change usually requires to restart video streaming | ||
| // TODO: check video streaming status instead of using a hardcoded timeout | ||
| func (n *Native) useExtraLock(fn func() error) error { |
Contributor
There was a problem hiding this comment.
Could this queuing-up be better handled by pushing the change into a channel to be handled inside a go-routine that serves up the changes in-order?
|
|
||
| uint32_t detected_width, detected_height; | ||
| bool detected_signal = false, streaming_flag = false; | ||
| bool detected_signal = false, streaming_flag = false, streaming_stopped = true; |
Contributor
There was a problem hiding this comment.
Shouldn't we declare streaming_stopped as volatile so the compiler knows that another thread might be mucking with them? (streaming_flag is protected by mutex, so should be fine, but wouldn't hurt to declare it volatile as well?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.