refactor: ota redirecting #898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in useVersion hook
IDisposable
reviewed
Oct 23, 2025
IDisposable
reviewed
Oct 23, 2025
IDisposable
reviewed
Oct 23, 2025
IDisposable
reviewed
Oct 23, 2025
IDisposable
reviewed
Oct 23, 2025
IDisposable
reviewed
Oct 23, 2025
Contributor
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
Looks pretty good, this will replace #838
…eoutMs, implement exponential backoff for retries
IDisposable
approved these changes
Oct 27, 2025
Contributor
IDisposable
left a comment
IDisposable
left a comment
There was a problem hiding this comment.
There are some other little things I did in my attempt, that I can stack over this when it is merged, but this looks good to go now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useJsonRPCAPI to a non-reactive interface./settings/general/updatechecks for updates on our API. The DNS might not be ready, so added timeouts and retries.appversionandsystemversionto the OTA redirect urlRedirectUrltoRedirectTo