fix: Fix video quality #913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced the static stream factor with a configurable video quality factor. The new implementation saves the updated quality factor to the configuration, ensuring persistence across sessions.
ym
approved these changes
Oct 29, 2025
Contributor
|
Thank goodness it was a bug, the artifacts were driving me crazy! |
Contributor
Author
|
@adrianmeraz Until this is released, you can set it to low and then back to high again, and it should work. |
1 task
ym
added a commit
that referenced
this pull request
Nov 15, 2025
Co-authored-by: Adam Shiervani <adam.shiervani@gmail.com> fix: video quality (#913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got reports that the video quality decreased in the last release.
The issue was no default stream quality factor, and therefore it was falling back on 0, which effectively puts the default stream in "Low" mode.
Additionally, when setting and getting the video quality stream, we didn't store the value in the config but updated a local quality variable that was used in the old implementation.