fix: show HDMI overlays in fullscreen mode #974
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jetkvm#919 where HDMI error overlays ("No HDMI signal detected") were not visible when video was in fullscreen mode. Changes: - Add fullscreenContainerRef to target the container div - Update requestFullscreen() to make container fullscreen instead of video - Update releaseKeyboardLock() to check container instead of video - Attach ref to container div that includes both video and overlays This ensures overlays are descendants of the fullscreen element and thus visible according to the Fullscreen API specification. Previously: video element went fullscreen, overlays (siblings) invisible Now: container with video + overlays goes fullscreen, all visible
|
|
adamshiervani
approved these changes
Nov 17, 2025
pennycoders
pushed a commit
to pennycoders/kvm
that referenced
this pull request
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919 where HDMI error overlays ("No HDMI signal detected") were not visible when video was in fullscreen mode.
Changes:
This ensures overlays are descendants of the fullscreen element and thus visible according to the Fullscreen API specification.
Previously: video element went fullscreen, overlays (siblings) invisible
Now: container with video + overlays goes fullscreen, all visible