Fix paste modal character detection for Spanish and accented characters #976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jetkvm#957 - Paste modal now correctly detects Spanish characters requiring AltRight modifier (@, |, #) and accented characters (ñ) by normalizing all input text to NFC form before keyboard layout lookup. Root cause: macOS and other sources may provide text in NFD (decomposed) form while keyboard layouts store characters in NFC (composed) form. JavaScript object property lookup requires exact byte match, causing lookups to fail despite characters being defined. Solution: Apply .normalize('NFC') to all user input characters before validation and paste execution. Testing: Browser-based validation testing completed with Spanish keyboard layout (es-ES) using text from multiple sources (TextEdit, Safari, Notes) on macOS. Hardware testing requires JetKVM device.
adamshiervani
approved these changes
Nov 17, 2025
pennycoders
pushed a commit
to pennycoders/kvm
that referenced
this pull request
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #957 - Paste modal now correctly detects Spanish characters requiring AltRight modifier (@, |, #) and accented characters (ñ) by normalizing all input text to NFC form before keyboard layout lookup.
Root cause: macOS and other sources may provide text in NFD (decomposed) form while keyboard layouts store characters in NFC (composed) form. JavaScript object property lookup requires exact byte match, causing lookups to fail despite characters being defined.
Solution: Apply .normalize('NFC') to all user input characters before validation and paste execution.
Testing: Browser-based validation testing completed with Spanish keyboard layout (es-ES) using text from multiple sources (TextEdit, Safari, Notes) on macOS. Hardware testing requires JetKVM device.