Skip to content
This repository was archived by the owner on Jan 9, 2023. It is now read-only.

Updates vault helper and unsealer to latest version #20

Merged
jetstack-bot merged 2 commits into from
Nov 8, 2017
Merged

Updates vault helper and unsealer to latest version #20

jetstack-bot merged 2 commits into from
Nov 8, 2017

Conversation

@JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Oct 25, 2017 •
edited by simonswine
Loading

Closes #16 #17

Update vendored vault-helper and vault-unsealer to latest releases

@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Oct 25, 2017

@JoshVanL: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Oct 25, 2017
@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Oct 25, 2017

Hi @JoshVanL. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 25, 2017
@simonswine
Copy link
Contributor

simonswine commented Oct 25, 2017

/ok-to-test

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2017
@simonswine simonswine assigned JoshVanL and unassigned munnerz and kragniz Nov 2, 2017
@simonswine simonswine added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 2, 2017
@simonswine
Copy link
Contributor

simonswine commented Nov 2, 2017

@JoshVanL can you look at this again?

@JoshVanL JoshVanL force-pushed the latest-vault-tool-versions branch from 4b1c54d to 9dfba49 Compare November 8, 2017 14:08
@jetstack-bot jetstack-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2017
@JoshVanL JoshVanL force-pushed the latest-vault-tool-versions branch from 9dfba49 to 39f521f Compare November 8, 2017 16:39
@simonswine simonswine removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 8, 2017
@simonswine
Copy link
Contributor

simonswine commented Nov 8, 2017

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2017
@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Nov 8, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2017
@jetstack-bot
Copy link
Collaborator

jetstack-bot commented Nov 8, 2017

Automatic merge from submit-queue.

@jetstack-bot jetstack-bot merged commit a2658ba into jetstack:master Nov 8, 2017
simonswine pushed a commit to JoshVanL/tarmak that referenced this pull request Mar 23, 2018
@jetstack-bot
Merge pull request jetstack#20 from simonswine/api-kubelet-auth
36b4a56 
Fix SAN names on kubelet certs
simonswine pushed a commit to simonswine/tarmak that referenced this pull request Mar 28, 2018
@jetstack-bot
Merge pull request jetstack#20 from simonswine/endpoint-reconciler
eb000e2 
Kube-apiserver should use endpoint reconciler in 1.9+
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@simonswine simonswine

@JoshVanL JoshVanL

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoshVanL @jetstack-bot @simonswine @munnerz @kragniz