Introduce idr.Node caching and recycling
#84
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2020 18:10
The key diff/improvement is now we add xpath to the csv reader so that we can perform both positive row selection as well as negative row skipping. Much more powerful than the old row skipping thingy. Next PR will bring the FileFormat implementation in, which will complete the csv fileformat.
As a result, adding `Release(*idr.Node)` to `FormatReader` so that `Ingester` will free up `*idr.Node` allocations for recycling Updated all benchmarks. No degradation so far. The reason the json sample bench mark didn't improve much is because there isn't much nodes allocated per read. However typically in the CSV parsing/transform scenarios, files are usually very long and node allocation caching saving would start to show significantly.
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
===========================================
- Coverage 100.00% 99.62% -0.38%
===========================================
Files 35 35
Lines 1552 1587 +35
===========================================
+ Hits 1552 1581 +29
- Misses 0 6 +6
Continue to review full report at Codecov.
|
|
somehow the last commit refuses to show up. seems github sync issue. will close and recreate the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result, adding
Release(*idr.Node)toFormatReaderso thatIngesterwill free up*idr.Nodeallocations for recyclingUpdated all benchmarks.
No degradation so far. The reason the json sample bench mark didn't improve much is because there isn't much nodes allocated per read. However typically in the CSV parsing/transform scenarios, files are usually very long and node allocation caching saving would start to show significantly.
resolves #83