Skip to content

Scripted pipeline - Append build info instead of override #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

Scripted pipeline - Append build info instead of override #200

merged 1 commit into from
May 16, 2020

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Apr 8, 2020 •
edited
Loading

To allow users to set build info values before the actual step, let's append the build info object instead of overriding it.

For example, setting build name and number:

buildInfo.name = "frog"
buildInfo.number = "1"

will be overridden by:

buildInfo = rtDocker.push ARTIFACTORY_DOCKER_REGISTRY + '/hello-world:latest', 'docker-local'

@yahavi yahavi requested a review from eyalbe4 April 8, 2020 06:02
@yahavi yahavi self-assigned this Apr 8, 2020
@yahavi yahavi merged commit 8dcbfb1 into jfrog:master May 16, 2020
@yahavi yahavi deleted the buildinfo-append branch May 16, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yahavi yahavi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yahavi @eyalbe4