Make fenced code blocks add the class to code rather than pre#71
Merged
jgm merged 1 commit intocommonmark:masterfrom Sep 7, 2014
mathiasbynens:patch-1
Merged
Make fenced code blocks add the class to code rather than pre#71jgm merged 1 commit intocommonmark:masterfrom mathiasbynens:patch-1
class to code rather than pre#71jgm merged 1 commit intocommonmark:masterfrom
mathiasbynens:patch-1
Conversation
This matches the convention set out in the HTML Living Standard (http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-code-element) and makes existing syntax highlighting scripts recognize the programming language used. Ref. http://talk.standardmarkdown.com/t/fenced-code-blocks-should-add-class-to-code-rather-than-pre-matching-the-html-best-practice/136
|
+1 |
mathiasbynens
changed the title
classto code rather than preclass to code rather than pre
Contributor
|
I do think this is a good idea. |
jgm
added a commit
that referenced
this pull request
Sep 7, 2014
Make fenced code blocks add the `class` to `code` rather than `pre`
jgm
added a commit
that referenced
this pull request
Sep 7, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the convention set out in the HTML Living Standard (http://www.whatwg.org/specs/web-apps/current-work/multipage/semantics.html#the-code-element) and makes existing syntax highlighting scripts recognize the programming language used.
Ref. http://talk.standardmarkdown.com/t/fenced-code-blocks-should-add-class-to-code-rather-than-pre-matching-the-html-best-practice/136