Skip to content

Conversation

mpapis
Copy link
Collaborator

@mpapis mpapis commented Jan 7, 2014

The current style of check configuration is a hard-coded list of checks, or we fall back to a hard-coded list of defaults in code:

git config pre-commit.checks "foo, bar"

or

DEFAULT_CHECKS = [:foo, :bar]

With the new style of configuration #107 the semantics have changed. We need to make sure that:

  • People with old configuration are not disrupted.
  • People with old configuration do not experience errors.

@mpapis
Copy link
Collaborator

mpapis commented Jan 7, 2014

no tests for this one, tested it manually ... I guess we drop it anyway for 1.0.0 release.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2c88157 on bugfix/migrate_old_git_config into 831d8b2 on master.

@mpapis
Copy link
Collaborator

mpapis commented Jan 7, 2014

actually why not add tests :)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2116065 on bugfix/migrate_old_git_config into 831d8b2 on master.

mpapis added a commit that referenced this pull request Jan 7, 2014
Git configuration should be backwards compatible
@mpapis mpapis merged commit 537f9c7 into master Jan 7, 2014
@mpapis mpapis deleted the bugfix/migrate_old_git_config branch January 7, 2014 05:08
@jish
Copy link
Owner Author

jish commented Jan 7, 2014

"actually why not add tests :)"

:)

@jish jish mentioned this pull request Jan 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants