Skip to content

Conversation

gy
Copy link

@gy gy commented Jan 15, 2014

No description provided.

@mpapis
Copy link
Collaborator

mpapis commented Jan 15, 2014

👍

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 142cf18 on georgeyacoub:rubocop_ambiguous_constant into 2e30c5e on jish:master.

jish added a commit that referenced this pull request Jan 15, 2014
Solved uninitialized constant when running Rubocop.
@jish jish merged commit 6ba41b8 into jish:master Jan 15, 2014
@gy gy deleted the rubocop_ambiguous_constant branch January 15, 2014 20:36
@pawelnguyen
Copy link

@jish do you mind pushing new version to rubygems? this change for sure isn't available when running gem install pre-commit and it took me a while to find the issue with robocup :)

@mpapis
Copy link
Collaborator

mpapis commented Feb 11, 2014

@jish maybe we could release 0.13.alpha1 ?

@pawelnguyen
Copy link

it's a bit confusing - what's up with 0.12 and 0.13 (in readme)? wouldn't it be easier to prepare new version on separate brunch, you would be able to bump up bugfixes at 0.12 :)

@mpapis
Copy link
Collaborator

mpapis commented Feb 11, 2014

@pawelnguyen the 0.12 is currently released version of gem, we have a lot of changes on master which could be improved even more before releasing full version (minor bump), but this should not stop us from releasing an alpha version as most of the changes on master should work just fine - we have tests for them ;)

@jish I can push the alpha/beta versions (or even full releases) if you add me as owner on rubygems (http://guides.rubygems.org/command-reference/#gem_owner)

@jish
Copy link
Owner

jish commented Feb 12, 2014

Hey, sorry guys. I think the reason I was holding off on this was because I was worried about backwards compatibility with the configuration changes.

I think we have those addressed now though, so I think it should be safe to release a new version.

@jish
Copy link
Owner

jish commented Feb 12, 2014

Guys, this project has diverged too far... :( I can't even run the tests locally =/

@jish
Copy link
Owner

jish commented Feb 12, 2014

I've been trying to get them to run locally for about an hour, I might have to call it for the night. I'll try for a bit longer, but this might have to wait until tomorrow.

@jish
Copy link
Owner

jish commented Feb 12, 2014

Ok, I figured everything out, and released a new version. Sorry for all of the spam messages!

Hopefully everything works out for you. If not, please file a new issue and we'll try to sort it out. Thanks for your patience.

@pawelnguyen
Copy link

👍 thanks for quick reaction. I've installed 0.13 and it works fine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants