Skip to content

Conversation

mpapis
Copy link
Collaborator

@mpapis mpapis commented Dec 28, 2013

@gy
Copy link

gy commented Jan 6, 2014

If it's not too much trouble can you rebase and force push onto this branch so we know which commits apply for this PR. Thank you @mpapis.

@mpapis
Copy link
Collaborator

mpapis commented Jan 6, 2014

updated, down to one commit\

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5f4495c on features/csslint into 831d8b2 on master.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this just for documentation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now just documentations so others know in future what was used for it, but it can be later extended to also serve as source for updates

@jish
Copy link
Owner Author

jish commented Jan 7, 2014

Looks pretty good. (:

@mpapis
Copy link
Collaborator

mpapis commented Jan 7, 2014

updated

@jish
Copy link
Owner Author

jish commented Jan 8, 2014

I merged in master, but the tests look like they're failing... =/

@mpapis
Copy link
Collaborator

mpapis commented Jan 8, 2014

it's the rubinius gems, nothing related to actual tests ... I will try to look into it (in travel till Friday)

Conflicts:
	test/unit/pre-commit/cli_test.rb
@mpapis
Copy link
Collaborator

mpapis commented Jan 8, 2014

removed support for rubinius, it causes problems also in other rubies, as long as they can not decide to build something that works out of the box we can not support it

@mpapis
Copy link
Collaborator

mpapis commented Jan 8, 2014

and it works just fine now (still waiting on jruby - but it should be all fine)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling baec057 on features/csslint into a9872e3 on master.

jish added a commit that referenced this pull request Jan 8, 2014
@jish jish merged commit 2e30c5e into master Jan 8, 2014
@jish jish deleted the features/csslint branch January 8, 2014 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants