Move "Add open folder in addon context menu" to develop branch (#64)#70
Merged
jliddev merged 5 commits intoWowUp:developfrom Sep 30, 2020
Merged
Move "Add open folder in addon context menu" to develop branch (#64)#70jliddev merged 5 commits intoWowUp:developfrom
jliddev merged 5 commits intoWowUp:developfrom
Conversation
Note I had to add System.ComponentModel.Annotations from nuget for it to build
Xathz
commented
Sep 29, 2020
Xathz
commented
Sep 29, 2020
| addon1.ClientType == addon2.ClientType; | ||
| } | ||
|
|
||
| public static string GetFullFolderPath(this Addon addon, IWarcraftService warcraftService) => Path.GetFullPath(Path.Combine(warcraftService.GetAddonFolderPath(addon.ClientType), addon.FolderName)); |
Contributor
Author
There was a problem hiding this comment.
This should probably go in the IWarcraftService
Originally posted by @jliddev in #64 (comment)
Do you want an addon feature to be in there?
Member
There was a problem hiding this comment.
Good point, AddonService is probably more appropriate since it already references Warcraft service. Having it be an extension seems out of place with dependency injection.
jliddev
approved these changes
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #64