-
Notifications
You must be signed in to change notification settings - Fork 1
Improvements & bug fixes #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Replace single-line input box with modern comment editor - Improve user experience for adding notes via keyboard shortcut - Ensure consistent behavior between CodeLens and keyboard shortcut note creation - Open comment editor with proper markdown support and formatting options - Remove manual content input in favor of comment editor workflow - Update command handler in `src/extension.ts` to use `openCommentEditor()` Resolves keyboard shortcut note creation UX inconsistency, providing a more robust and user-friendly method for adding contextual notes to code selections.
- Update `addNote` command to use comment editor UI instead of input box - Refactor `viewHistory` command to show history in comment thread - Ensure consistent user experience across all note interaction methods - Add support for markdown formatting in comment editor - Improve error handling for commands when no workspace is open Keyboard shortcuts now provide a more modern and integrated experience: - Ctrl+Alt+N opens comment editor for adding notes - Ctrl+Alt+H shows note history inline in comment thread - Preserves context and provides better markdown editing capabilities - Aligns with CodeLens and button interaction patterns Fixes inconsistent UI behavior introduced in previous versions of the extension.
…icon - Updated `handleSaveNewNote` method to support threads created by VSCode's + icon - Added fallback mechanism to find document by URI when custom properties are missing - Implemented robust document retrieval strategy: 1. Check custom `sourceDocument` property first 2. Find document by matching thread URI in workspace documents 3. Attempt to open document via `vscode.workspace.openTextDocument()` - Added error handling for scenarios where document cannot be found - Ensures comment saving works consistently across different thread creation methods - Provides clear error messages when document retrieval fails Resolves issue with comment editor not saving notes when using VSCode's native + icon in editor gutter
…agement - Add comprehensive documentation for comment editor architecture and lifecycle - Implement auto-collapse of other notes when working on a single note - Fix keyboard shortcuts to use modern comment UI with markdown support - Resolve issue with + icon comment editor saving notes - Update nyc test coverage configuration after esbuild migration - Improve comment thread state tracking and management - Add new helper method `closeAllCommentEditors()` in CommentController - Enhance user experience with more informative labels and clearer actions - Ensure better handling of temporary, editing, and viewing thread states Addresses complex comment editor interaction challenges and provides a more focused, user-friendly note-taking experience in the extension.
- Implement complete note thread disposal in `closeAllCommentEditors()` - Fully hide all comment threads when opening a new editor - Add Ctrl+Enter (Cmd+Enter) keyboard shortcut for saving notes - Update comment thread management to ensure clean, focused editing experience - Improve UX by removing visual clutter from collapsed notes Closes #ISSUE_NUMBER (if applicable)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
💡 Enable Vercel Agent with $100 free credit for automated AI reviews |
|
Caution Review failedThe pull request is closed. WalkthroughRelease v0.1.5 introduces auto-collapse behavior for notes with single-editor focus enforcement, adds keyboard shortcut (Ctrl+Enter) for saving, improves document resolution in save workflows, updates UI labels and history rendering, and includes extensive documentation for the comment editor system. Changes
Sequence DiagramsequenceDiagram
actor User
participant UI as Comment Editor UI
participant Controller as commentController
participant Storage as NoteManager
participant VSCode as VSCode API
rect rgb(220, 240, 255)
Note over Controller: New Save-focused Flow (v0.1.5)
end
User->>UI: Opens editor (Keyboard/CodeLens/+ icon)
UI->>Controller: openCommentEditor()
Controller->>Controller: closeAllCommentEditors()
Controller->>VSCode: Create temp thread (tempId, sourceDocument)
VSCode->>UI: Display input thread
User->>UI: Types note, presses Ctrl+Enter
UI->>Controller: handleSaveNewNote()
rect rgb(240, 255, 240)
Note over Controller: Enhanced Document Resolution
end
Controller->>Controller: Resolve target document<br/>(from sourceDocument or search)
alt Document not found
Controller->>VSCode: Open document
end
Controller->>Storage: Save note via NoteManager
Storage-->>Controller: Note with UUID
rect rgb(255, 240, 240)
Note over Controller: Lifecycle Transition
end
Controller->>VSCode: Dispose temp thread
Controller->>VSCode: Create permanent thread (note UUID)
Controller->>Controller: closeAllCommentEditors()
VSCode->>UI: Display saved note in collapsed state
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Mixed complexity: multiple documentation files follow repetitive structure (lower effort), but functional changes in Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
closeAllCommentEditors()Closes #ISSUE_NUMBER (if applicable)
Summary by CodeRabbit
New Features
Bug Fixes