Skip to content

support for top volume on last 24h endpoint#34

Merged
joancaron merged 1 commit intojoancaron:masterfrom
monsieurleberre:topby24hvolumefull
Dec 14, 2018
Merged

support for top volume on last 24h endpoint#34
joancaron merged 1 commit intojoancaron:masterfrom
monsieurleberre:topby24hvolumefull

Conversation

@monsieurleberre
Copy link
Copy Markdown
Contributor

↪️ Pull Request

Add support for the endpoint at https://min-api.cryptocompare.com/data/top/totalvolfull

💻 Examples

Just one more endpoint supported, nothing else :)

🚨 Test instructions

Debug the integration test provided to check that it works

💥 Does this PR introduce a breaking change?

  • No

✔️ PR Todo

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joancaron joancaron merged commit 1738e82 into joancaron:master Dec 14, 2018
@joancaron
Copy link
Copy Markdown
Owner

Hello @monsieurleberre
Thank you again for this contribution !

@monsieurleberre monsieurleberre deleted the topby24hvolumefull branch December 14, 2018 11:13
@monsieurleberre
Copy link
Copy Markdown
Contributor Author

monsieurleberre commented Dec 14, 2018

My pleasure :) 👍
@joancaron do you think you could publish an updated nuget package ? Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants