Skip to content

Moves KVO registration into -(id)init #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2014
Merged

Moves KVO registration into -(id)init #9

merged 1 commit into from
Jan 18, 2014

Conversation

@keichan34
Copy link

I was getting some errors on -(void)dealloc, on this line:

[self removeObserver:self forKeyPath:@"socketState"];

Moving KVO registration into -(id)init will make sure that KVO is always registered.

kolinkrewinkel added a commit that referenced this pull request Jan 18, 2014
@kolinkrewinkel
Merge pull request #9 from Untitled-Co/fix-kvo-crash-on-dealloc
6a884ce 
Moves KVO registration into `-(id)init`
@kolinkrewinkel kolinkrewinkel merged commit 6a884ce into joeldev:master Jan 18, 2014
@keichan34 keichan34 deleted the fix-kvo-crash-on-dealloc branch January 18, 2014 01:54
@keichan34 keichan34 mentioned this pull request Feb 15, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keichan34 @kolinkrewinkel