Skip to content

Show remaining time on a task on the tray#4156

Merged
johannesjo merged 3 commits intosuper-productivity:masterfrom
panoramix360:feature/show-timer-macos-top
Apr 15, 2025
Merged

Show remaining time on a task on the tray#4156
johannesjo merged 3 commits intosuper-productivity:masterfrom
panoramix360:feature/show-timer-macos-top

Conversation

@panoramix360
Copy link
Contributor

@panoramix360 panoramix360 commented Mar 18, 2025

Description

The idea is to show the remaining time of a task on the tray icon at the top.

Issues Resolved

List any existing issues this PR resolves
#3091

When you play a task that has an estimate time, it shows the remaining time

image

When you play a task that does not have an estimate time, it shows the time spent on the task until now

image

When the user has the Pomodoro timer enabled, it shows the rest of the pomodoro session:

image

cc: @johannesjo @9z0

@panoramix360
Copy link
Contributor Author

I created this PR as a draft so we can test on other environments and see what happens here.

Can you guys test on Linux if possible? I'll test this on Windows.

I didn't implemented the timer when the Pomodoro is enabled, do you think that's a good thing to have? I'll probably need to understand a little how can I add this to get the current pomodoro timer on the event process of the Store/dispatch.

@panoramix360
Copy link
Contributor Author

Just manage to add the Pomodoro timer on the tray timer when the pomodoro is enabled! yay!

image

The only issue is, the tray timer seem to be slower than the one inside the application, sometimes they are not totally in sync, I don't know if this is huge problem.

but since I never used the ngrx, @johannesjo can you review the code and see if I messed up?

Thank you!

@panoramix360 panoramix360 marked this pull request as ready for review March 18, 2025 23:49
@johannesjo
Copy link
Collaborator

Thanks for the changes! On gnome there is still nothing shown unfortunately. Maybe we could try using something like this:

https://www.npmjs.com/package/@girs/node-appindicator3-0.1

?

@johannesjo
Copy link
Collaborator

Thank you!

@johannesjo johannesjo merged commit 7f9fa07 into super-productivity:master Apr 15, 2025
5 of 6 checks passed
@panoramix360 panoramix360 deleted the feature/show-timer-macos-top branch April 15, 2025 18:44
@panoramix360
Copy link
Contributor Author

hey @johannesjo, sorry for not testing that on Windows yet.

I'll try to do it this week, let you know once I figured it out, and maybe I could open another PR.

I'll probably just not able to test on Linux, did you manage to see it something there?

@johannesjo
Copy link
Collaborator

I'll probably just not able to test on Linux, did you manage to see it something there?

No. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments