Cleaned up and replace mocha with jest #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
john-ko
commented
Feb 29, 2020
john-ko
commented
- Updated README.md
- Changed unit tests from mocha to jest
- Updated test to get 100% coverage
- Updated syntax and make more readable
- Cleaned up code
- Removed unused npm scripts and dev deps.
Feature/promise
john-ko
commented
Feb 29, 2020
| @@ -1,87 +0,0 @@ | |||
| import loadScript from '../../src/index' | |||
There was a problem hiding this comment.
dangit i forgot the main script
nicohsieh
reviewed
Feb 29, 2020
README.md
Outdated
| - https://bitsofco.de/async-vs-defer/ | ||
| - https://flaviocopes.com/javascript-async-defer/ | ||
| - will fallback to whichever is Best practice | ||
| - also since this script is most likely loaded on content load and scriptloading is done after, might not matter? should test. |
There was a problem hiding this comment.
Did some research and realized that dynamic script are async by default! https://javascript.info/script-async-defer#dynamic-scripts Looks like we don't even have to add it~! Maybe it can be a patch later, if so I can create an issue for it 😁
nicohsieh
reviewed
Feb 29, 2020
Closed
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.