Skip to content

Conversation

@Engerim
Copy link
Contributor

@Engerim Engerim commented Feb 5, 2019

* run tests with phpunit 8.0
* allow failures for dev-master runs
@johnkary
Copy link
Owner

johnkary commented Feb 7, 2019

Hi @Engerim, Thank you for adding this support to the build matrix! Looks like things are working well against PHPUnit 8.

Could you please see my comment about having removed nightly from the build matrix?

@Engerim
Copy link
Contributor Author

Engerim commented Feb 7, 2019

Hi @johnkary I don't see any comment about the nightly build, but I can add the nightly php again

@johnkary
Copy link
Owner

johnkary commented Feb 8, 2019

@Engerim Yes, could we please add - nightly back to PHP build matrix?

* php nightly is for now php 8.0.0-dev instead of 7.4.0-dev so i allow them to fail for now 
* see also this tweet and comments https://twitter.com/kelunik/status/1094228271942848518?s=21
@Engerim
Copy link
Contributor Author

Engerim commented Feb 9, 2019

Nightly is added again, but with allowed failures. php nightly is for now php 8.0.0-dev instead of 7.4.0-dev so i allow them to fail for now.
See also this tweet and comments https://twitter.com/kelunik/status/1094228271942848518?s=21

Also interesting https://travis-ci.community/t/add-php-7-4-branch-to-test-against/2179

@mazsudo
Copy link

mazsudo commented Feb 12, 2019

any plan to merge/release this @johnkary ? love this library and would be glad to keep using it with phpunit8 ;)
could also help to preprare a next version as TestListener interface seems deprecated now with phpunit8 if you want ;)

@Engerim
Copy link
Contributor Author

Engerim commented Feb 19, 2019

ping @johnkary everything works

@johnkary johnkary merged commit 43306c8 into johnkary:master Feb 24, 2019
@johnkary
Copy link
Owner

@Engerim Thank you for your help to allow PHPUnit 8 compatibility!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compatibility with phpunit 8?

3 participants