-
Notifications
You must be signed in to change notification settings - Fork 62
Allow PHPUnit 8 #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow PHPUnit 8 #53
Conversation
* run tests with phpunit 8.0 * allow failures for dev-master runs
…his php version anymore
|
Hi @Engerim, Thank you for adding this support to the build matrix! Looks like things are working well against PHPUnit 8. Could you please see my comment about having removed nightly from the build matrix? |
|
Hi @johnkary I don't see any comment about the nightly build, but I can add the nightly php again |
|
@Engerim Yes, could we please add |
* php nightly is for now php 8.0.0-dev instead of 7.4.0-dev so i allow them to fail for now * see also this tweet and comments https://twitter.com/kelunik/status/1094228271942848518?s=21
|
Nightly is added again, but with allowed failures. php nightly is for now php 8.0.0-dev instead of 7.4.0-dev so i allow them to fail for now. Also interesting https://travis-ci.community/t/add-php-7-4-branch-to-test-against/2179 |
|
any plan to merge/release this @johnkary ? love this library and would be glad to keep using it with phpunit8 ;) |
|
ping @johnkary everything works |
|
@Engerim Thank you for your help to allow PHPUnit 8 compatibility! |
Uh oh!
There was an error while loading. Please reload this page.