chore: enable eslint-plugin-perfectionist on typescript-estree package (typescript-eslint#9852)

* chore: enable eslint-plugin-perfectionist on typescript-estree package

* fix: convert.ts ordering

* Thanks Kirk, moved keywords to beginning

Author: JoshuaKGoldberg

eslint.config.mjs

@@ -614,6 +614,7 @@ export default tseslint.config(
       'packages/type-utils/{src,tests,typings}/**/*.ts',
       'packages/types/{src,tools}/**/*.ts',
       'packages/typescript-eslint/{src,tests}/**/*.ts',
+      'packages/typescript-estree/{src,tests,typings}/**/*.ts',
       'packages/utils/src/**/*.ts',
       'packages/visitor-keys/src/**/*.ts',
       'packages/website*/src/**/*.ts',
@@ -626,7 +627,7 @@ export default tseslint.config(
       'perfectionist/sort-union-types': [
         'error',
         {
-          groups: ['unknown', 'keyword', 'nullish'],
+          groups: ['keyword', 'unknown', 'nullish'],
           type: 'natural',
         },
       ],
@@ -683,4 +684,19 @@ export default tseslint.config(
       ],
     },
   },
+  {
+    files: ['packages/typescript-estree/src/**/*.ts'],
+    rules: {
+      'perfectionist/sort-objects': [
+        'error',
+        {
+          customGroups: {
+            first: ['type'],
+            second: ['loc', 'range'],
+          },
+          groups: ['first', 'second'],
+        },
+      ],
+    },
+  },
 );

packages/ast-spec/src/base/LiteralBase.ts

@@ -4,5 +4,5 @@ import type { BaseNode } from './BaseNode';
 export interface LiteralBase extends BaseNode {
   type: AST_NODE_TYPES.Literal;
   raw: string;
-  value: RegExp | bigint | boolean | number | string | null;
+  value: bigint | boolean | number | string | RegExp | null;
 }

packages/ast-spec/src/type/TSMappedType/spec.ts

@@ -9,8 +9,8 @@ export interface TSMappedType extends BaseNode {
   constraint: TypeNode;
   key: Identifier;
   nameType: TypeNode | null;
-  optional: '+' | '-' | boolean | undefined;
-  readonly: '+' | '-' | boolean | undefined;
+  optional: boolean | '+' | '-' | undefined;
+  readonly: boolean | '+' | '-' | undefined;
   typeAnnotation: TypeNode | undefined;
   /** @deprecated Use {@link `constraint`} and {@link `key`} instead. */
   typeParameter: TSTypeParameter;

packages/eslint-plugin/src/rules/ban-ts-comment.ts

@@ -5,9 +5,9 @@ import { AST_TOKEN_TYPES } from '@typescript-eslint/utils';
 import { createRule, getStringLength, nullThrows } from '../util';
 
 type DirectiveConfig =
+  | boolean
   | 'allow-with-description'
-  | { descriptionFormat: string }
-  | boolean;
+  | { descriptionFormat: string };
 
 interface Options {
   minimumDescriptionLength?: number;

packages/eslint-plugin/src/rules/class-methods-use-this.ts

@@ -13,7 +13,7 @@ type Options = [
   {
     enforceForClassFields?: boolean;
     exceptMethods?: string[];
-    ignoreClassesThatImplementAnInterface?: 'public-fields' | boolean;
+    ignoreClassesThatImplementAnInterface?: boolean | 'public-fields';
     ignoreOverrideMethods?: boolean;
   },
 ];

packages/eslint-plugin/src/rules/member-ordering.ts

@@ -995,7 +995,7 @@ export default createRule<Options, MessageIds>({
 
       // Standardize config
       let order: Order | undefined;
-      let memberTypes: MemberType[] | string | undefined;
+      let memberTypes: string | MemberType[] | undefined;
       let optionalityOrder: OptionalityOrder | undefined;
 
       /**

packages/eslint-plugin/src/rules/naming-convention-utils/types.ts

@@ -23,7 +23,7 @@ interface MatchRegex {
 
 interface Selector {
   custom?: MatchRegex;
-  filter?: MatchRegex | string;
+  filter?: string | MatchRegex;
   // format options
   format: PredefinedFormatsString[] | null;
   leadingUnderscore?: UnderscoreOptionsString;

packages/eslint-plugin/src/rules/no-invalid-void-type.ts

@@ -6,7 +6,7 @@ import { createRule } from '../util';
 
 interface Options {
   allowAsThisParameter?: boolean;
-  allowInGenericTypeArguments?: [string, ...string[]] | boolean;
+  allowInGenericTypeArguments?: boolean | [string, ...string[]];
 }
 
 type MessageIds =

packages/eslint-plugin/src/rules/no-misused-promises.ts

@@ -18,7 +18,7 @@ type Options = [
   {
     checksConditionals?: boolean;
     checksSpreads?: boolean;
-    checksVoidReturn?: ChecksVoidReturnOptions | boolean;
+    checksVoidReturn?: boolean | ChecksVoidReturnOptions;
   },
 ];
 
@@ -43,7 +43,7 @@ type MessageId =
   | 'voidReturnVariable';
 
 function parseChecksVoidReturn(
-  checksVoidReturn: ChecksVoidReturnOptions | boolean | undefined,
+  checksVoidReturn: boolean | ChecksVoidReturnOptions | undefined,
 ): ChecksVoidReturnOptions | false {
   switch (checksVoidReturn) {
     case false:

packages/eslint-plugin/src/rules/no-restricted-types.ts

@@ -6,13 +6,13 @@ import { createRule, objectReduceKey } from '../util';
 
 type Types = Record<
   string,
+  | boolean
+  | string
   | {
       fixWith?: string;
       message: string;
       suggest?: readonly string[];
     }
-  | boolean
-  | string
   | null
 >;
 
@@ -37,7 +37,7 @@ function stringifyNode(
 }
 
 function getCustomMessage(
-  bannedType: { fixWith?: string; message?: string } | true | string | null,
+  bannedType: string | { fixWith?: string; message?: string } | true | null,
 ): string {
   if (!bannedType || bannedType === true) {
     return '';