Skip to content

Conversation

@johnsosoka
Copy link
Owner

Changes

  • Update version references to 0.4.0
  • Add 6 edge case tests for stats resource
  • Verify response size documentation against live API
  • Fix test assertion specificity

Test Results

  • 84/84 tests passing
  • 98% coverage on stats client
  • All quality checks passing

John Sosoka added 2 commits November 22, 2025 09:14
Add three new enums for improved type safety and IDE autocomplete:
- StatsRankType (OPEN, WOMEN) - used in 8 stats endpoints
- SystemCode (OPEN, WOMEN) - used in overall() endpoint
- MajorTournament (YES, NO) - used in lucrative_tournaments()

All enums maintain full backwards compatibility with string parameters
via union types (Enum | str).

Changes:
- Add enum definitions to models/common.py
- Update stats client signatures to accept enums
- Export enums from main package
- Add 21 new tests (15 enum tests + 6 quality improvements)
- Update documentation with enum usage examples

Benefits:
- Type safety: catch typos at development time
- IDE autocomplete: discover available values
- Self-documenting: clear what values are valid
- No breaking changes: strings still work
…coverage

Update version references from 0.3.0 to 0.4.0 across all documentation
and source files. Add 6 high-value edge case tests for stats resource
and verify response size documentation against live API.

Version Updates:
- Update pyproject.toml and __init__.py version to 0.4.0
- Update README "What's New" section to reference 0.4.0
- Update installation docs example output to show 0.4.0

Test Improvements:
- Add empty response handling test
- Add malformed API response validation (2 tests)
- Add invalid date format handling test
- Add enum/string equivalence test
- Add period endpoints smoke test (integration)
- Fix overly permissive assertion in validation test

Documentation:
- Verify response sizes via live API calls (2025-11-22)
- Update stats.md with accurate counts for all endpoints
- Add verification date and performance tips
- Document default 25-result limit for period queries

All 84 tests passing, 98% coverage on stats client maintained.
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2025

Codecov Report

❌ Patch coverage is 95.83333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/ifpa_api/resources/stats/client.py 94.28% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@johnsosoka johnsosoka merged commit e5b9aa5 into develop Nov 22, 2025
10 checks passed
@johnsosoka johnsosoka deleted the feature/v0.4.0-enhancements branch November 22, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants