Skip to content

Drop support of PHP 8.1, Add support of PHP 8.4, and update tooling #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 12, 2025
Merged

Drop support of PHP 8.1, Add support of PHP 8.4, and update tooling #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a6b9f5
Drop support of PHP 8.1
lyrixx Nov 22, 2024
9bc7e4d
Add support of PHP 8.4
lyrixx Nov 22, 2024
2a9034a
Update tools, and lock their versions
lyrixx Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 31 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
strategy:
matrix:
php-versions:
- '8.1'
- '8.2'
- '8.3'
- '8.4'

steps:
- uses: actions/checkout@v3
Expand All @@ -30,17 +30,44 @@ jobs:
- name: Install dependencies
run: composer install --prefer-dist --no-progress

- name: Run tests
run: composer test

php-cs-fixer:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to split it because php-cs-fixer could not work with PHP 8.4 for now.
An anyway, it's useless to run it 3 times.

By extension, I also did that for phpstan

name: Run PHP CS Fixer
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.2'

- name: Install PHP CS Fixer
run: composer install --prefer-dist --no-progress --working-dir=tools/php-cs-fixer

- name: Run PHP CS Fixer
run: composer cs-check

phpstan:
name: Run PHPStan
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3

- name: Setup PHP
uses: shivammathur/setup-php@v2
with:
php-version: '8.4'

- name: Install dependencies
run: composer install --prefer-dist --no-progress

- name: Install PHPStan
run: composer install --prefer-dist --no-progress --working-dir=tools/phpstan

- name: Run PHPStan
run: composer phpstan

- name: Run tests
run: composer test
7 changes: 3 additions & 4 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
.idea
.phpunit.cache
.php-cs-fixer.cache
.phpstan-cache
composer.lock
/.php-cs-fixer.cache
/.phpunit.cache
/composer.lock
vendor
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Not released yet

* Drop support of PHP 8.1
* Add support of PHP 8.4

## 0.2.0 (2024-10-02)

* Remove mb_string extension requirement
Expand Down
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,16 @@
}
},
"require": {
"php": ">=8.1"
"php": ">=8.2"
},
"require-dev": {
"symfony/phpunit-bridge": "^6.4"
},
"config": {
"sort-packages": true,
"platform": {
"php": "8.1.19"
}
},
"require-dev": {
"symfony/phpunit-bridge": "^6.3.1"
"php": "8.2"
},
"sort-packages": true
},
"scripts": {
"test": "vendor/bin/simple-phpunit",
Expand Down
9 changes: 8 additions & 1 deletion tools/php-cs-fixer/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
{
"require": {
"friendsofphp/php-cs-fixer": "^3.30"
"friendsofphp/php-cs-fixer": "^3.64"
},
"config": {
"bump-after-update": true,
"platform": {
"php": "8.2"
},
"sort-packages": true
}
}
Loading
Loading