Skip to content

Conversation

@jonasbn
Copy link
Collaborator

@jonasbn jonasbn commented Dec 11, 2021

Description

Please include a summary of the proposed improvement or addressed issue.

Fixes/addresses (If applicable) a violation of a Perl::Critic policy

REF: https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::ProhibitMixedBooleanOperators

Type of change

Please delete options that are not relevant.

. [x] This is a maintenance/coding style change

Checklist:

  • My code follows the style guidelines of this project, please see the contribution guidelines.
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

You might think, that this is one crazy checklist, but it is just as much written for the maintainer of the involved software :-)

@jonasbn jonasbn added this to the 1.58 milestone Dec 11, 2021
@jonasbn jonasbn added the maintenance Maintenance of tools and configuration label Dec 11, 2021
@jonasbn jonasbn requested a review from ehuelsmann December 11, 2021 20:05
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.169% when pulling b0a1ebb on ProhibitMixedBooleanOperators into 79f4706 on master.

Copy link
Member

@ehuelsmann ehuelsmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the only failure for this Critic, we have a very nice code base!

Fix looks good.

@jonasbn jonasbn merged commit 2c0814d into master Dec 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the ProhibitMixedBooleanOperators branch December 12, 2021 08:22
@jonasbn jonasbn restored the ProhibitMixedBooleanOperators branch January 27, 2022 16:42
@jonasbn
Copy link
Collaborator Author

jonasbn commented Jan 27, 2022

Cherry-picked onto 1.x branch for inclusion in 1.58

@jonasbn jonasbn deleted the ProhibitMixedBooleanOperators branch January 27, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Maintenance of tools and configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants