Add dialyzer and fix specs #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzamani
force-pushed
the
specs-and-dialyzer
branch
4 times, most recently
from
0840c2f to
0d67dad
Compare
hzamani
force-pushed
the
specs-and-dialyzer
branch
from
0d67dad to
ff0a6b2
Compare
1 similar comment
|
Nice! Thanks for taking care of that. Any ideas why the build is still failing for Elixir 1.4.5 with OTP 18.3? I can merge the PR once everything's green. |
|
Related? |
|
Definitely looks like a known issue, thanks for digging that up @odk211. I will merge the PR and exclude the Elixir |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.