Skip to content

Conversation

@jongalloway
Copy link
Owner

  • Use check emoji for NuGet push and add MCP registry publish steps to CI
  • Bump .mcp/server.json schema to 2025-10-17 and add "title" field
  • Add mcp-name metadata comment to README

- Use check emoji for NuGet push and add MCP registry publish steps to CI
- Bump .mcp/server.json schema to 2025-10-17 and add "title" field
- Add mcp-name metadata comment to README
@jongalloway jongalloway requested a review from Copilot October 24, 2025 23:13
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates CI/CD workflows and metadata to support publishing to the MCP Registry alongside existing NuGet publishing. The changes align with MCP registry publishing requirements by updating the server schema version, adding required metadata fields, and extending the publish workflow.

Key changes:

  • Updates MCP server schema to latest version (2025-10-17) and adds required "title" field
  • Extends publish workflow to include MCP Registry authentication and publishing steps
  • Adds MCP registry identifier metadata comment to README

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
README.md Adds mcp-name metadata comment for MCP registry identification
DotNetMcp/.mcp/server.json Updates schema version and adds title field per MCP registry requirements
.github/workflows/publish-nuget.yml Extends workflow with MCP registry login and publish steps

Comment on lines 144 to 145
run: |
curl -L "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloading and executing binaries from external sources without verification poses a security risk. Add checksum verification or pin to a specific release version instead of using 'latest' to ensure reproducibility and security.

Suggested change
run: |
curl -L "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
env:
MCP_PUBLISHER_VERSION: v0.4.0
run: |
set -e
OS="$(uname -s | tr '[:upper:]' '[:lower:]')"
ARCH="$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/')"
TARBALL="mcp-publisher_${OS}_${ARCH}.tar.gz"
CHECKSUM_FILE="${TARBALL}.sha256"
BASE_URL="https://github.com/modelcontextprotocol/registry/releases/download/${MCP_PUBLISHER_VERSION}"
echo "Downloading MCP Publisher $MCP_PUBLISHER_VERSION for $OS/$ARCH"
curl -fsSL -o "$TARBALL" "$BASE_URL/$TARBALL"
curl -fsSL -o "$CHECKSUM_FILE" "$BASE_URL/$CHECKSUM_FILE"
echo "Verifying checksum..."
sha256sum -c "$CHECKSUM_FILE"
tar xzvf "$TARBALL" mcp-publisher

Copilot uses AI. Check for mistakes.
- name: Install MCP Publisher
run: |
curl -L "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tar extraction command is missing the '-C' flag to specify extraction directory, and 'mcp-publisher' at the end appears to be attempting to filter archive members but is incorrect syntax. Use 'tar xz -C . mcp-publisher' or 'tar xz ./mcp-publisher' to properly extract the binary.

Suggested change
curl -L "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz mcp-publisher
curl -L "https://github.com/modelcontextprotocol/registry/releases/latest/download/mcp-publisher_$(uname -s | tr '[:upper:]' '[:lower:]')_$(uname -m | sed 's/x86_64/amd64/;s/aarch64/arm64/').tar.gz" | tar xz -C . mcp-publisher

Copilot uses AI. Check for mistakes.
Use curl -fsSL for robust download, make the fetched mcp-publisher executable, and verify the installed version.
@jongalloway jongalloway merged commit fa18e4a into main Oct 24, 2025
1 check passed
@jongalloway jongalloway deleted the add-registry-publishing branch October 24, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants