Skip to content

[WIP]: Code Review annotations for WebP #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 142 commits into
base: master
Choose a base branch
from
Draft

[WIP]: Code Review annotations for WebP #1

wants to merge 142 commits into from

Conversation

@jongleur1983
Copy link
Owner

@jongleur1983 jongleur1983 commented Mar 14, 2020

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

jongleur1983 and others added 30 commits October 11, 2019 22:39
@jongleur1983
Initial Commit towards WebP
dc84968
@brianpopow
Add empty implementation of IImageDecoder to test github colaboration
8eed360
@jongleur1983
introduce decoderCore classes (without implementation)
7f3af8e
@brianpopow
First attempt parsing minimal image info
d54cbc3
@brianpopow
Identify works at least for reading the image dimensions so far
e9969ef
@martonl
WebP test input files added, test skeletons added (copied from Bmp te…
3441e56 
…sts)
@brianpopow
First attempt parsing minimal image info, infoIdentify works at least…
89080b9 
… for reading the image dimensions so far
@jongleur1983
fix typo
4e77257
@martonl
WebP tests WIP
c5474e9
@brianpopow
Add reading of VP8X header
30712d4
@brianpopow
Additional webp constants, first attempt parsing VP8L header
0d8e813
@martonl
WebP Identify test added, webp sample files copied from official samp…
19563f0 
…les repository
@martonl
Two sample images missed
3bc1bbf
@brianpopow
Add bitreader for a VP8L stream. Determining image size for VP8L shou…
cb92eea 
…ld work now.
@jongleur1983
height comes before width, switch order.
f35465a
@brianpopow
Parsing the transforms (still WIP)
ccc7e5e
@brianpopow
Add additional chunk header constants
72e273e
@brianpopow
Parsing of image features of VP8X header
10b3443
@brianpopow
Use the width and height from the VP8X information, if present
acd80c9
@brianpopow
Refactor determining chunk types
e69ea45
@martonl
Some Lossy files added to WebPDecoder Identify test. Test is broken w…
2ced96a 
…ith new sample files.
@martonl
Animated webp sample added to Identify test
df96513
@brianpopow
Skipping over optional chunks with VP8X images (still does not seem t…
6d71a0c 
…o work)
@brianpopow
Fix mistake with parsing VP8X header
39a6bf5
@martonx
BitsPerPixel Assert added to webp Identify_DetectsCorrectDimensions test
5a4fbec
@brianpopow
Initialize metadata
6e94934
@brianpopow
Add parsing optional chunks at the end
762c5bc
@brianpopow
Add to the metadata, if the image is lossy or lossless and also if a …
5ff81d4 
…animation is present
@brianpopow
Throwing not supported exception for animated images
9ea185e
@brianpopow
Add all found chunk types to the metadata
d9b7e55 
Note: this does not seem to work in all cases at the moment
@brianpopow
Implementing FinishRow, EmitRgb
6bd5ebd
@brianpopow
Fix modes probabilities
1d532f4
@brianpopow
Implement functions for luma modes
6e60e3b
@brianpopow
Fix setting Y/UV-Stride
a801c52
@brianpopow
Implement TrueMotion
01d7f2e
@brianpopow
Implement macroblock filtering (still not working: the extra rows in …
1640a7f 
…yuv buffer for filtering are missing)
@brianpopow
Add lossy webp specification
325c29e
@brianpopow
Replicate the top-right pixels in 4x4 block
059b07a
@brianpopow
Move lookup tables to separate file
4cea3a8
@brianpopow
Add webp lossy tests
0e21c6a
@brianpopow
Fix webp lossy decoding bug
65cf078
@brianpopow
Additional webp lossy tests
c274276
@brianpopow
Enable macroblock filtering
2ab691c
@brianpopow
Fix some lossy decoding bugs
ff701c0
@brianpopow
Add more webp lossy test cases
bf758f7
@brianpopow
Fix decoding very small lossy webp images
a26d86c
@brianpopow
Additional test cases for webp lossy images
240b156
@brianpopow
Add decode webp benchmark
4c66366
@brianpopow
A little cleanup and refactoring
e2cd0d8
@brianpopow
Start implementing alpha decoding: uncompressed alpha without filteri…
fc1003d 
…ng works so far
@brianpopow
Start implementing compressed alpha decoding
3f3b445
@brianpopow
Add filtering for uncompressed alpha
592e5b1
@brianpopow
Add filtering for compressed alpha
3f0a1cd
@brianpopow
Fix decoding issues
885b3fb 
- Lossless: Check if transforms are present on dispose
- Lossy: Set filterinfo properly
@brianpopow
Vp8Decoder reserves only needed memory
d806e75
@brianpopow
Vp8Decoder now uses memory allocator
4cf09ce
@brianpopow
Use bulk pixel conversion
e510e41
@brianpopow
Merge remote-tracking branch 'jongleur_upstream/WebP' into webp
87a8099 
# Conflicts:
#	src/ImageSharp/Configuration.cs
#	tests/ImageSharp.Tests/TestImages.cs
#	tests/Images/External
@brianpopow
Fix solution file due to merge error
7f90c02
@brianpopow
Add tests for reading webp metadata, fix some test images with metadata
27c7149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jongleur1983 @brianpopow @martonl @martonx