3.0.0-alpha.3: missing 'std' feature for 'chrono' #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Since the commit 514735e which remove the "default features" for the dependency 'chrono', I now have this error : ``` imap-3.0.0-alpha.3/src/client.rs:202:37 format!(" \"{}\"", date.format("%d-%h-%Y %T %z")) ^^^^ method not found in `DateTime<FixedOffset>>` ``` So I think we have to add back the 'std' feature to 'chrono' ``` chrono = {version = "0.4", default-features = false, features = ["std"]} ``` (I know that I could add this dependency to my project Cargo.toml (and I did), but I think this should be in rust-imap)
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 15 15
Lines 1722 1722
=======================================
Hits 1338 1338
Misses 384 384 Continue to review full report at Codecov.
|
Owner
|
Huh, interesting. @alexwennerberg I wonder why you didn't run into this? |
Contributor
|
@jonhoo Hmm, I’m not sure, my apologies though! Go ahead and add it back. |
jonhoo
approved these changes
Apr 21, 2021
Owner
|
@ValHeimer Thanks! Will be part of the next alpha/release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Since the commit 514735e which remove the "default features" for the dependency 'chrono', I now have this error :
So I think we have to add back the 'std' feature to 'chrono'
(I know that I could add this dependency to my project Cargo.toml (and I did), but I think this should be in rust-imap)
This change is