This repository was archived by the owner on Jan 7, 2022. It is now read-only.
Add and style sort priority to sorted column headers #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 19.98% (diff: 100%)@@ master #59 diff @@
==========================================
Files 45 45
Lines 1321 1321
Methods 169 169
Messages 0 0
Branches 307 307
==========================================
Hits 264 264
Misses 1057 1057
Partials 0 0
|
jonshaffer
suggested changes
Jan 10, 2017
Owner
jonshaffer
left a comment
jonshaffer
left a comment
There was a problem hiding this comment.
looks good to me minus a class for future styling of that sort-priority integer
| ng-click="hcell.onSorted()"> | ||
| </span> | ||
| <span ng-class="hcell.sortClass()"></span> | ||
| <span ng-class="hcell.sortClass()">{{hcell.column.sortPriority}}</span> |
Collaborator
Author
There was a problem hiding this comment.
It's already using the sort-btn class
Owner
There was a problem hiding this comment.
going to roll this into future class audit for this component
jonshaffer
approved these changes
Jan 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For feature #32