-
-
Notifications
You must be signed in to change notification settings - Fork 19
Add a "resolve" method to Path #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think this will not work under windows. |
Co-Authored-By: Michael Babker <michael.babker@gmail.com>
Co-Authored-By: Michael Babker <michael.babker@gmail.com>
Co-Authored-By: Michael Babker <michael.babker@gmail.com>
I don't think this fixes that. I think people in that issue who have symlinks are largely symlink'ing Having said that this method seems logical and useful anyhow - just don't think you're going to fix the issue mentioned |
It does fix it. We are running into the current issue because we are using |
|
@wilsonge any follow up on this here form your site? |
|
Nah feel free to merge. I've said my piece |
Summary of Changes
I added a new "resolve" method to resolve relative paths without the need for the input path to be an absolute path in the first place. The path in question also doesn't need to exist beforehand, it's a virtual check.
This also allows a better fix for joomla/joomla-cms#24539 that doesn't break symlinks.