auto-dismiss #128
Merged
auto-dismiss #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to have auto-dismiss with and without the manual dismiss x Thanks @C-Lodder
wilsonge
reviewed
Sep 17, 2019
src/js/alert/alert.js
Outdated
|
|
||
| /* Lifecycle, element appended to the DOM */ | ||
| connectedCallback() { | ||
| this.setAttribute('role', 'alertdialog'); |
Contributor
Contributor
Author
There was a problem hiding this comment.
my mistake - should not have changesd
Contributor
Author
There was a problem hiding this comment.
I just copy/pasted @C-Lodder code after testing it for autodismiss. Didnt spot these other changes. I guess he edited an older version of the file. I will put them back and retest before updating this PR
Contributor
Author
There was a problem hiding this comment.
OK should be correct now. I revert the dialog changes and retested and all seems good.
Contributor
Author
|
I "think" this might fix the error we are getting on the main repo as well
|
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to have auto-dismiss with and without the manual dismiss x
Thanks @C-Lodder