external links #18
Merged
external links #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docusauris uses _to_ for internal links and _href_ for external links This way the link gets the icon to indicate that the link opens in a new tab etc. In the footer the two community links were done this way but the More and Legal Links were not. This PR corrects that
Member
|
same as in the other pr noticed, footer is not part of the documentation but I merge this anyway. and j4i info drone builds a preview of the pr which can be found in the checks of course having a screenshot is good too |
Contributor
Author
/me confused Do you mean that the footer here will be replaced by the cdn? |
Member
|
when I figure out how to do it I will add the standard joomla.org footer to the documentation:
I already try but failed to add a simple html file to the footer... |
Contributor
Author
|
ah i understand you now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docusauris uses to for internal links and href for external links
This way the link gets the icon to indicate that the link opens in a new tab etc.
In the footer the two community links were done this way but the More and Legal Links were not.
This PR corrects that
after