Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla 3.9.10 merge #26107

Closed
wants to merge 39 commits into from
Closed

Joomla 3.9.10 merge #26107

wants to merge 39 commits into from

Conversation

wilsonge
Copy link
Contributor

  • Merge with a merge not squash/rebase

HLeithner and others added 30 commits June 11, 2019 22:39
* Media field style and layout

* Small screen considerations

* Tweaks

* Revert js change

* indent

* Fix scroll in chrome
Chosen is not accessible so we shouldnt use it unless it offers something useful.

In the search component in the front end there are potentially two lists Ordering and display #

Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
The $key parameter can be either an array or a string but from PHPDoc it was only an array
* Improvements to mediamanager.js and popup-imagemanager.js
 - use jquery's prop function instead of attr
 - properly and consistently encode and decode URI components
 - explicitly use global variables from the global scope

* Wait till the iframe is loaded before doing things that required the iframe to be loaded.
@wilsonge wilsonge changed the base branch from staging to 4.0-dev August 31, 2019 22:25
@wilsonge wilsonge closed this Aug 31, 2019
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed Unit/System Tests labels Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet