New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joomla 3.9.10 merge #26107
Closed
Closed
Joomla 3.9.10 merge #26107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wilsonge
commented
Aug 31, 2019
- Merge with a merge not squash/rebase
* Media field style and layout * Small screen considerations * Tweaks * Revert js change * indent * Fix scroll in chrome
Chosen is not accessible so we shouldnt use it unless it offers something useful. In the search component in the front end there are potentially two lists Ordering and display # Neither of these require or benefit from chosen so this simple PR returns them to regular and accessible lists
The $key parameter can be either an array or a string but from PHPDoc it was only an array
* Improvements to mediamanager.js and popup-imagemanager.js - use jquery's prop function instead of attr - properly and consistently encode and decode URI components - explicitly use global variables from the global scope * Wait till the iframe is loaded before doing things that required the iframe to be loaded.
…k on Plus (+) button to add repeated subform joomla#25387 (joomla#25398)
…oomla#25406) Pinned sodium_compat because of file case change, atm this could not be handled by the Joomla! updater.
Joomla! 3.9.10
joomla-cms-bot
added
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-4.0-dev
and removed
Unit/System Tests
labels
Aug 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.