Skip to content

Conversation

@jorenham
Copy link
Owner

@jorenham jorenham commented Oct 13, 2025

No description provided.

Copilot AI review requested due to automatic review settings October 13, 2025 15:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the np_assert_allclose! macro to support both f64 and Complex<f64> values by adding helper methods to the existing ExtendedErrorArg trait and updating the macro implementation to use these trait methods instead of type-specific operations.

  • Added xsf_magnitude() and xsf_is_nan() helper methods to the ExtendedErrorArg trait
  • Updated np_assert_allclose! macro to work generically with both numeric types
  • Simplified test code by removing custom assertion helpers and using the updated macro

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/xsf/fp_error_metrics.rs Added helper methods to ExtendedErrorArg trait for magnitude and NaN checking
src/macros.rs Updated np_assert_allclose macro to use trait methods instead of f64-specific operations
src/xsf/fresnel.rs Replaced local assert_allclose function with np_assert_allclose macro
src/xsf/sph_harm.rs Simplified nested loops to use np_assert_allclose macro

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham
Copy link
Owner Author

This is an experiment to see how capable copilot is nowadays

@jorenham jorenham requested a review from Copilot October 13, 2025 15:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham
Copy link
Owner Author

This is an experiment to see how capable copilot is nowadays

Conclusion; pretty incapable

@jorenham jorenham force-pushed the feat/complex-assert-allclose branch from aab4479 to 9e39ce6 Compare October 13, 2025 16:03
@jorenham jorenham changed the title Add Complex<f64> support to np_assert_allclose macro Add complex support to np_assert_allclose macro Oct 13, 2025
@jorenham jorenham requested a review from Copilot October 13, 2025 16:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham force-pushed the feat/complex-assert-allclose branch from 9e39ce6 to c55bc9c Compare October 13, 2025 16:12
@jorenham jorenham requested a review from Copilot October 13, 2025 16:12
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham force-pushed the feat/complex-assert-allclose branch from c55bc9c to f0cf1b0 Compare October 13, 2025 16:20
@jorenham jorenham requested a review from Copilot October 13, 2025 16:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham force-pushed the feat/complex-assert-allclose branch from f0cf1b0 to b38ac3b Compare October 13, 2025 16:25
@jorenham jorenham requested a review from Copilot October 13, 2025 16:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jorenham jorenham requested a review from Copilot October 13, 2025 17:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit 609318b into master Oct 13, 2025
7 checks passed
@jorenham jorenham deleted the feat/complex-assert-allclose branch October 13, 2025 17:02
@jorenham jorenham added this to the 0.2.1 milestone Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant