Skip to content

Conversation

@jorenham
Copy link
Owner

closes #128

Copilot AI review requested due to automatic review settings October 27, 2025 17:09
@jorenham jorenham added this to the 0.3.1 milestone Oct 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements Stirling numbers of the second kind as a new function stirling2 in the xsf-rust library. The implementation provides a pure Rust translation of scipy.special.stirling2(n, k, exact=True).

Key changes:

  • Adds stirling2<T> function with dynamic programming implementation and special case optimizations
  • Includes comprehensive documentation with mathematical notation and cross-references
  • Provides test coverage using precomputed values in a lookup table

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/scipy_special/stirling.rs New module implementing stirling2 function with dynamic programming algorithm, special case handling, and test suite
src/scipy_special/mod.rs Module declaration and public re-export of stirling functions
src/lib.rs Updated combinatorics documentation table to include stirling2 instead of planned placeholder

@jorenham jorenham requested a review from Copilot October 27, 2025 19:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

@jorenham jorenham merged commit cd8ef17 into master Oct 27, 2025
7 checks passed
@jorenham jorenham deleted the stirling2 branch October 27, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

some kind of Stirling numbers

1 participant