fix: avoid xsf(build) reruns, don't rerun if autogened header changed #132
Conversation
|
hey @jorenham I see an unrelated fail in the Lint job, should it be fixed here or do you plan on opening a separate PR to take care of it ? :) |
|
Ah lemme fix the new 1.91 clippy issue real quick in a separate PR |
|
let's see what to robot has to say in the meantime |
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the build script to avoid unnecessary reruns by disabling header file modification time tracking in bindgen's CargoCallbacks. Since the C++ header files are generated deterministically by the build script itself, their modification time changes shouldn't trigger rebuilds.
- Adds
.rerun_on_header_files(false)to the bindgen CargoCallbacks configuration
|
the new clippy warnings are fixed on master, so if you could rebase this then those checkmarks should turn nice and green |
- bindgen via the CargoCallbacks can rerun the build script if headers and various files have changed - the header here being auto-generated it can appear as having changed vs. the build timestamp because it will always be generated after the script invokation so the timestamp can appear as having changed - disable the rerun on header change, given the header is unique for a given xsf version it should be fine
IceTDrinker
force-pushed
the
am/fix/do-not-rerun-bindgen-on-autogenerated-header-change
branch
from
56afa15 to
b7dadb4
Compare
|
rebase done |
|
Did you by any chance notice any other issues? Otherwise I'll do a quick release now. |
|
Not that I can think of no, I have a very limited usage to be able to use the mathematically stable primitives of scipy in rust |
2 participants
fixes: #131
hopefully
I have been able to verify that it was fixing the issue on my end and all the other rerun-if-changed emitted by bindgen are kept