Skip to content

Conversation

@jorenham
Copy link
Owner

@jorenham jorenham commented Sep 5, 2025

  • prolate_aswfa[_nocv]
  • oblate_aswfa[_nocv]
  • prolate_radial1[_nocv]
  • oblate_radial1[_nocv]
  • prolate_radial2[_nocv]
  • oblate_radial2[_nocv]

Copilot AI review requested due to automatic review settings September 5, 2025 14:38
@jorenham jorenham added this to the 0.1.0 milestone Sep 5, 2025

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jorenham jorenham requested a review from Copilot September 5, 2025 14:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for prolate and oblate spheroidal angular and radial functions by implementing 12 new functions in the spheroidal wave module. These functions compute spheroidal functions of the first and second kinds along with their derivatives, with variants that either compute characteristic values internally or accept pre-computed ones.

  • Implements 6 _nocv variant functions that compute characteristic values internally
  • Implements 6 functions that accept pre-computed characteristic values for better performance
  • Adds comprehensive test coverage for all new functions using the existing test framework

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/sphd_wave.rs Implements 12 new spheroidal function wrappers with full documentation
src/lib.rs Exports all new functions from the sphd_wave module
build.rs Adds function type signatures for binding generation
tests/test_functions.rs Adds test macros and test cases for all new functions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit 0d8cc78 into master Sep 5, 2025
4 checks passed
@jorenham jorenham deleted the sphd_wave branch September 5, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant