Skip to content

Conversation

@jorenham
Copy link
Owner

@jorenham jorenham commented Sep 7, 2025

No description provided.

Copilot AI review requested due to automatic review settings September 7, 2025 20:42
@jorenham jorenham added this to the 0.1.0 milestone Sep 7, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR consolidates utility functions by merging utils.rs into bindings.rs, eliminating a separate module for a single utility function. The c_complex64_nan() function is moved to bindings.rs and renamed to complex_nan() for better consistency with the module's purpose.

  • Removed the utils.rs module entirely
  • Moved the c_complex64_nan() function to bindings.rs as complex_nan()
  • Updated all call sites to use the new function location and name

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/utils.rs Deleted the entire file containing the c_complex64_nan() function
src/lib.rs Removed the mod utils; declaration
src/bindings.rs Added the complex_nan() function and reorganized imports
src/sici.rs Updated function calls and removed utils import
src/kelvin.rs Updated function calls and removed utils import
src/fresnel.rs Updated function calls and removed utils import
src/airy.rs Updated function calls and removed utils import

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit acf94b8 into master Sep 7, 2025
7 checks passed
@jorenham jorenham deleted the rm-utils branch September 7, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant