Skip to content

Conversation

@jorenham
Copy link
Owner

@jorenham jorenham commented Sep 9, 2025

  • legendre_p_all
  • sph_legendre_p_all
  • assoc_legendre_p_all
  • lqmn

This also removes the out-of-scope-for-a-cpp-bindings-crate lqn alias.

Copilot AI review requested due to automatic review settings September 9, 2025 21:15
@jorenham jorenham added this to the 0.1.0 milestone Sep 9, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Rust bindings for the remaining *_all Legendre functions from the underlying mathematical library, completing the Legendre function bindings set. The changes enable computing arrays of Legendre polynomials at once rather than individually.

  • Adds legendre_p_all, sph_legendre_p_all, assoc_legendre_p_all, and lqmn function bindings
  • Refactors existing associated Legendre functions to use a unified interface with normalization parameter
  • Removes the out-of-scope lqn alias (keeping the function itself)

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
src/lib.rs Adds extern crate alloc and updates public exports to include new functions
src/legendre.rs Implements all new *_all function bindings with Vec return types and comprehensive tests
src/bindings.rs Adds helper functions for complex number handling and Vec conversions
build.rs Adds C++ wrapper code for the new Legendre function bindings

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit 005addd into master Sep 9, 2025
7 checks passed
@jorenham jorenham deleted the legendre_p_all branch September 9, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant