Skip to content

Conversation

@jorenham
Copy link
Owner

  • ber_zeros
  • bei_zeros
  • ker_zeros
  • kei_zeros
  • berp_zeros
  • beip_zeros
  • kerp_zeros
  • keip_zeros
  • kelvin_zeros

Copilot AI review requested due to automatic review settings September 12, 2025 15:28
@jorenham jorenham added this to the 0.1.0 milestone Sep 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for computing zeros of Kelvin functions and their derivatives. It introduces 9 new public functions for finding the first nt zeros of individual Kelvin functions (ber, bei, ker, kei) and their derivatives (berp, beip, kerp, keip), plus a convenience function that returns zeros for all functions at once.

Key changes:

  • Adds 8 individual zero-finding functions and 1 convenience function
  • Modifies the kelvin function to return an array instead of a tuple for consistency
  • Includes comprehensive test coverage with reference values from scipy

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/lib.rs Exports the new Kelvin zero functions
src/kelvin.rs Implements zero-finding functions and updates kelvin function signature
build.rs Adds C++ wrapper for the klvnzo function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit 177566f into master Sep 12, 2025
7 checks passed
@jorenham jorenham deleted the kelvin_zeros branch September 12, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant