Skip to content

Conversation

@jorenham
Copy link
Owner

towards #87 (cerzo)

Copilot AI review requested due to automatic review settings October 12, 2025 22:22
@jorenham jorenham added this to the 0.2.0 milestone Oct 12, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new erf_zeros function to compute the zeros of the error function erf(z) in the first quadrant of the complex plane. The implementation leverages the existing cerzo function from the specfun library.

  • Adds erf_zeros function that returns an array of complex zeros
  • Updates module exports and documentation to include the new function
  • Adds comprehensive test coverage comparing against scipy reference values

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/xsf/mod.rs Exports the new erf_zeros function
src/xsf/erf.rs Implements erf_zeros function and adds test coverage
src/lib.rs Updates documentation table to include erf_zeros
build.rs Adds C++ wrapper for the cerzo function from specfun library
Comments suppressed due to low confidence (1)

src/xsf/erf.rs:1

  • Corrected spelling of 'speceial' to 'special'.
use core::ffi::c_int;

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jorenham jorenham merged commit 43c43c3 into master Oct 12, 2025
7 checks passed
@jorenham jorenham deleted the erf_zeros branch October 12, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant