Implement symref (HEAD) forwarding #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was simply assumed that HEAD always points to refs/heads/master but as it turns out that is far from true. Now HEAD is queried per repo from the upstream and forwarded. Unfortunately it seems that it is not avoidable to to an extra request to the upstream server for this. (calling ls-remote)
With the new git release sometimes the merge will be done by "ort" instead of "recursive". We don't really care about that as the results are the same.
christian-schilling
force-pushed
the
cs
branch
from
a72f18d to
5c26807
Compare
LMG
approved these changes
Nov 26, 2021
| type Polls = | ||
| Arc<std::sync::Mutex<std::collections::HashSet<(String, josh_proxy::auth::Handle, String)>>>; | ||
|
|
||
| type HeadsMap = Arc<std::sync::RwLock<std::collections::HashMap<String, String>>>; |
Collaborator
There was a problem hiding this comment.
Why a RwLock here, or more precisely why doesn't it also benefit the places where we use Mutex?
Member
Author
There was a problem hiding this comment.
You are right that a Mutex would probably work just as well given how small the critical section actually is. It is a very read heavy thing though. In the end I don't think we will be able to tell the difference with regards to performance. If any of this shared structures will ever turn out be an actual bottleneck we will need something else anyway...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was simply assumed that HEAD always points to
refs/heads/master but as it turns out that is far from true.
Now HEAD is queried per repo from the upstream and forwarded.
Unfortunately it seems that it is not avoidable to to an extra
request to the upstream server for this. (calling ls-remote)