Skip to content

Conversation

@josh
Copy link
Owner

@josh josh commented Nov 13, 2025

Summary

  • drop mermaid-cli from the plugins package inputs and snacks extra packages
  • relax the snacks health checks to ignore missing Mermaid CLI warnings

Testing

  • nix flake check --accept-flake-config --show-trace --print-build-logs --keep-going

Codex Task

Copilot AI review requested due to automatic review settings November 13, 2025 18:28
Copilot finished reviewing on behalf of josh November 13, 2025 18:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the mermaid-cli dependency from the lazy-nvim-nix package to reduce dependencies and simplify the build. Since mermaid diagram rendering is an optional feature, the health checks are updated to ignore the expected warnings about missing Mermaid CLI.

  • Removed mermaid-cli from package inputs and snacks.nvim extra packages
  • Updated health check ignore lists to suppress mermaid-related warnings

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
plugins.nix Removed mermaid-cli from function parameters and snacks.nvim extraPackages list
pkgs/tests/snacks-nvim-checkhealth.nix Added ignore patterns for mmdc tool not found error and mermaid diagram warning
pkgs/LazyVim.nix Added ignore patterns for mmdc tool not found error and mermaid diagram warning in snacks health check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@josh josh merged commit 3c0685a into renovate/lock-file-maintenance Nov 13, 2025
10 checks passed
@josh josh deleted the codex/remove-mermaid-cli-dependency branch November 13, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants