Remove compiler warning, fix examples #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New versions of the Arduino IDE throw a compiler warning
if you pass a const char * aka string literal ("hello world") to
a char * function argument. This commit changes the prototype to
take a const char *.
The examples did not compile since cmdInit was changed to accept a Stream reference instead of a serial port speed. This change fixes all examples. It also adds a new function cmdGetStream(). This allows command functions to get access to the same stream that is used by the command interpreter itself. If you change a sketch from using the serial port to using a different stream, you can simply change the initialisation of the cmd module and all command functions can remain unchanged. The commit also contains a fix to ignore \n characters as they are usually not part of a valid command. This way, the code works with all terminals, no matter if they send \r or \r\n line endings.
|
I've added one more commit to fix the examples. Hope this is useful for you. |
jan-r
changed the title
|
Thank you so much. I appreciate the fix! |
|
You're welcome. I can contribute more changes in the future, but they will most likely break compatibility (like re-enabling the dot as an allowed input character, because I need the possibility to pass floating point numbers as command arguments). |
|
I don't think many people use it, so I'm happy to have you add new features even if it breaks compatibility. Just be sure to add a explanatory note in the readme |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New versions of the Arduino IDE throw a compiler warning
if you pass a const char * aka string literal ("hello world") to
a char * function argument. This commit changes the prototype to
take a const char *.