Skip to content

Conversation

@tjcelaya
Copy link
Contributor

Found another exception that's missing a request ID. Not sure if HttpHelper.annotateContextedException might be overkill in this case.

@tjcelaya tjcelaya requested review from cburroughs and dekobon June 28, 2017 19:08
@dekobon
Copy link
Contributor

dekobon commented Jun 28, 2017

To summarize my understanding of this change: you are adding context including a request id for checksum validation failure exceptions?

@tjcelaya
Copy link
Contributor Author

Your summary is correct.

Copy link
Contributor

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dekobon dekobon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjcelaya tjcelaya merged commit a3d6ec5 into TritonDataCenter:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants