Fix Java 9 Runtime Issues #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dekobon
commented
Nov 27, 2017
| import org.bouncycastle.jcajce.spec.GOST28147ParameterSpec; | ||
| import org.bouncycastle.jcajce.util.BCJcaJceHelper; | ||
| import org.objenesis.instantiator.sun.MagicInstantiator; | ||
| import org.objenesis.instantiator.sun.UnsafeFactoryInstantiator; |
Contributor
Author
There was a problem hiding this comment.
The implementation of MagicInstantiator was using a security problem in the JDK to perform construction less instantiation and in Java 9 the "security problem" was resolved with no backwards compatibility added. I switched to using the UnsafeFactoryInstantiator because it uses the Java unsafe package which is still available in Java 9 and is also available across different JVM vendors.
tjcelaya
suggested changes
Nov 27, 2017
Contributor
There was a problem hiding this comment.
I don't see warnings about module encapsulation in the Azul 9 logs, only deprecated usage of isAccessible, unchecked-casts and raw types. Please fix these wherever possible or add suppressions:
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/ReflectionUtils.java:[122,19] isAccessible() in java.lang.reflect.AccessibleObject has been deprecated
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/ReflectionUtils.java:[149,19] isAccessible() in java.lang.reflect.AccessibleObject has been deprecated
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/BaseBlockCipherSerializer.java:[145,38] found raw type: org.objenesis.instantiator.sun.UnsafeFactoryInstantiator
missing type arguments for generic class org.objenesis.instantiator.sun.UnsafeFactoryInstantiator<T>
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/BaseBlockCipherSerializer.java:[145,34] unchecked call to UnsafeFactoryInstantiator(java.lang.Class<T>) as a member of the raw type org.objenesis.instantiator.sun.UnsafeFactoryInstantiator
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/BaseBlockCipherSerializer.java:[147,38] found raw type: org.objenesis.instantiator.sun.UnsafeFactoryInstantiator
missing type arguments for generic class org.objenesis.instantiator.sun.UnsafeFactoryInstantiator<T>
[WARNING] /home/travis/build/joyent/java-manta/java-manta-client-kryo-serialization/src/main/java/com/joyent/manta/serialization/BaseBlockCipherSerializer.java:[147,34] unchecked call to UnsafeFactoryInstantiator(java.lang.Class<T>) as a member of the raw type org.objenesis.instantiator.sun.UnsafeFactoryInstantiator
Contributor
Author
|
Warnings have been resolved. |
Contributor
|
One last deprecation remains: |
tjcelaya
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referencing #356