This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Closed
Conversation
Member
|
A commit log should explain what changed and why. You're leaving me guessing now why you're changing that. |
Author
|
My explanation was insufficient. // Don't raise the hwm > 128MB |
Member
|
That comment is a hint that a HWM > 128 MB will be detrimental to performance, not that the HWM should be 128 MB. Thanks for the pull request but it's not necessary to change the current default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix MAX_HWM (8MB -> 128MB)