Conversation
|
Gyp still needs a couple of fixes before it will be ready for Mac CLT users. |
|
@indutny +1, you beat me to it :) @mistydemeo Like what? I'm getting reports that this version of gyp is working for CLT users in nodejs/node-gyp#341. |
|
@TooTallNate That patch doesn't address the Xcode version checking, which still uses xcodebuild, and thus can still tank the configure for users CLT-only users. I have a patch for that that I'll be submitting to gyp this evening. |
|
I'm inclined to land this anyway |
|
According to users in Homebrew, the current version doesn't actually work for most people. The next patch will fix it for sure. I can provide the patch here when I submit it to gyp, so you can include it downstream without waiting for gyp to merge if you want. |
|
(A version of the patch I'm submitting to gyp is already in the Homebrew formula for node and is confirmed to be working.) |
|
Does this upgrade in and of itself break homebrew users, or are they merely broken in the same way unless they had already installed gcc or xcode? Or is the homebrew formula patching gyp in place to make it work without xcode? |
|
The Homebrew formula is patching gyp in place to make it work without Xcode. It includes my earlier patch, now in gyp, and the one I'm submitting tonight. |
|
ok thanks, @mistydemeo I'll hold off on this until you get upstreamed then, I appreciate all the help and feedback on this! |
|
Both patches have now landed in gyp. |
|
Thanks, landed in 96dffb1 |
Suggested reviewer: @tjfontaine
fix #3681